Re: [libvirt] [PATCH v2] qemu : support persistent add/delete network interface

[Daniel Veillard <veillard redhat com>]

On Wed, May 18, 2011 at 06:21:30PM +0900, KAMEZAWA Hiroyuki wrote:
> v2 here. error path tested.
> 
> ==
> >From 73887fd3a37e3aa38bf4e031df9cf230e2635137 Mon Sep 17 00:00:00 2001
> From: KAMEZAWA Hiroyuki <kamezawa hiroyu jp fujitsu com>
> Date: Wed, 18 May 2011 15:14:28 +0900
> Subject: [PATCH] qemu - support persistent add/delete network interfaces
> 
> This patch allows to modify interfaces of domain(qemu).
> 
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa hiroyu jp fujitsu com>
> 
> * src/conf/domain_conf.c:
> (virDomainNetInsert)     : Insert a network device to domain definition.
> (virDomainNetIndexByMac) : Returns an index of net device in array.
> (virDomainNetRemoveByMac): Remove a NIC of passed MAC address.
> 
> * src/qemu/qemu_driver.c
> (qemuDomainAttachDeviceConfig): add codes for NIC.
> (qemuDomainDetachDeviceConfig): add codes for NIC.
> 
> Changelog v1->v2:
>   - fixed virDomainNetInsert
>   - removed target name check. (It seems I misunderstood something.)
>   - fixed error check in qemuDomainAttachDeviceConfig
>   - fixed error message in qemuDomainDetachDeviceConfig

  thanks, looks fine ACK, and pushed,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/