Re: [libvirt] [PATCHv4 4/7] interface: implement remote protocol for network config transaction API

["Daniel P. Berrange" <berrange redhat com>]

On Thu, May 26, 2011 at 12:17:42PM -0400, Laine Stump wrote:
> From: Michal Privoznik <mprivozn redhat com>
> 
> No change from previously ACKed patch
> ---
>  src/remote/remote_driver.c   |    3 +++
>  src/remote/remote_protocol.x |   17 ++++++++++++++++-
>  src/remote_protocol-structs  |    9 +++++++++
>  3 files changed, 28 insertions(+), 1 deletions(-)
> 
> diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
> index 1691dab..075fb56 100644
> --- a/src/remote/remote_driver.c
> +++ b/src/remote/remote_driver.c
> @@ -6909,6 +6909,9 @@ static virInterfaceDriver interface_driver = {
>      .interfaceCreate = remoteInterfaceCreate, /* 0.7.2 */
>      .interfaceDestroy = remoteInterfaceDestroy, /* 0.7.2 */
>      .interfaceIsActive = remoteInterfaceIsActive, /* 0.7.3 */
> +    .interfaceChangeBegin = remoteInterfaceChangeBegin, /* 0.9.2 */
> +    .interfaceChangeCommit = remoteInterfaceChangeCommit, /* 0.9.2 */
> +    .interfaceChangeRollback = remoteInterfaceChangeRollback, /* 0.9.2 */
>  };
>  
>  static virStorageDriver storage_driver = {
> diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x
> index f0da95d..a663b25 100644
> --- a/src/remote/remote_protocol.x
> +++ b/src/remote/remote_protocol.x
> @@ -1164,6 +1164,18 @@ struct remote_interface_destroy_args {
>      unsigned int flags;
>  };
>  
> +struct remote_interface_change_begin_args {
> +    unsigned int flags;
> +};
> +
> +struct remote_interface_change_commit_args {
> +    unsigned int flags;
> +};
> +
> +struct remote_interface_change_rollback_args {
> +    unsigned int flags;
> +};
> +
>  
>  /* Auth calls: */
>  
> @@ -2291,8 +2303,11 @@ enum remote_procedure {
>      REMOTE_PROC_DOMAIN_MIGRATE_PERFORM3 = 216, /* skipgen skipgen */
>      REMOTE_PROC_DOMAIN_MIGRATE_FINISH3 = 217, /* skipgen skipgen */
>      REMOTE_PROC_DOMAIN_MIGRATE_CONFIRM3 = 218, /* skipgen skipgen */
> -    REMOTE_PROC_DOMAIN_SET_SCHEDULER_PARAMETERS_FLAGS = 219 /* skipgen skipgen */
> +    REMOTE_PROC_DOMAIN_SET_SCHEDULER_PARAMETERS_FLAGS = 219, /* skipgen skipgen */
> +    REMOTE_PROC_INTERFACE_CHANGE_BEGIN = 220, /* autogen autogen */
>  
> +    REMOTE_PROC_INTERFACE_CHANGE_COMMIT = 221, /* autogen autogen */
> +    REMOTE_PROC_INTERFACE_CHANGE_ROLLBACK = 222 /* autogen autogen */
>      /*
>       * Notice how the entries are grouped in sets of 10 ?
>       * Nice isn't it. Please keep it this way when adding more.
> diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs
> index 414b4d5..a28cd13 100644
> --- a/src/remote_protocol-structs
> +++ b/src/remote_protocol-structs
> @@ -803,6 +803,15 @@ struct remote_interface_destroy_args {
>          remote_nonnull_interface   iface;
>          u_int                      flags;
>  };
> +struct remote_interface_change_begin_args {
> +        unsigned int flags;
> +};
> +struct remote_interface_change_commit_args {
> +        unsigned int flags;
> +};
> +struct remote_interface_change_rollback_args {
> +        unsigned int flags;
> +};
>  struct remote_auth_list_ret {
>          struct {
>                  u_int              types_len;

ACK


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|