[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] graphics: add support for action_if_connected in qemu



2011/5/30 Michal Privoznik <mprivozn redhat com>:
> This option accepts 3 values:
> -keep, to keep current client connected (Spice+VNC)
> -disconnect, to disconnect client (Spice)
> -fail, to fail setting password if there is a client connected (Spice)
> ---
>  docs/schemas/domain.rng  |   16 ++++++++++++++++
>  src/conf/domain_conf.c   |   44 +++++++++++++++++++++++++++++++++++++++++---
>  src/conf/domain_conf.h   |   11 +++++++++++
>  src/libvirt_private.syms |    2 ++
>  src/qemu/qemu_hotplug.c  |   11 ++++++++---
>  5 files changed, 78 insertions(+), 6 deletions(-)
>

Without reviewing this in detail, domain XML extensions must be
documented, but you patch lacks documentation.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]