Re: [libvirt] [PATCH] storage: List directory volumes for dir/fs/netfs pools

[Cole Robinson <crobinso redhat com>]

On 05/27/2011 08:39 AM, Richard W.M. Jones wrote:
> On Thu, May 26, 2011 at 01:25:24PM -0600, Eric Blake wrote:
>> On 05/26/2011 12:58 PM, Daniel P. Berrange wrote:
>>> On Thu, May 26, 2011 at 02:10:24PM -0400, Cole Robinson wrote:
>>>> Since directories can be used for <filesystem> passthrough, they are
>>>> basically storage volumes. Not sure if anyone has an opinion about
>>>> not listing directories like ., .., or lost+found, but this patch
>>>> doesn't do anything explicit with them.
>>>
>>> I think we should skip '.', '..', and 'lost+found' since they
>>> are special items, not things that can be used as volumes.
>>
>> Definitely skip '.' and '..'.
>>
>> 'lost+found' might be a legitimate real directory at non-mount points,
>> but skipping it is okay by me.
> 
> Also it's not called "lost+found" on all systems.  On Macs it's called
> "Lost and Found", and my Android phone has a directory called
> "LOST.DIR" although I'm not sure in the latter case if that's just an
> ordinary trash folder or acts as a true lost+found in the fsck sense.
> I think it's safer not to skip anything except "." and "..".
> 

Good point, I've sent a v4

Thanks,
Cole