[libvirt] [PATCH] Do not log invalid operations in libvirtd logs
Daniel Veillard
veillard at redhat.com
Tue Sep 13 10:25:45 UTC 2011
On Tue, Sep 13, 2011 at 11:19:43AM +0100, Daniel P. Berrange wrote:
> On Tue, Sep 13, 2011 at 06:14:32PM +0800, Daniel Veillard wrote:
> > This is a bit painful for example when starting virt-manager
> > it tends to clutter libvirtd.log with invalid operation on cpu pinning
> > for defined but not running domains. A priori those kind of errors
> > don't indicate an error when executing the command but on a precondition
> > for running the API, and honnestly while the application should report
> > it, logging it as an error in libvirtd.log is not really useful,
> >
> > Related bug: https://bugzilla.redhat.com/show_bug.cgi?id=590807
> >
> > Daniel
> >
> > diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
> > index 1a9fd82..c708ff7 100644
> > --- a/daemon/libvirtd.c
> > +++ b/daemon/libvirtd.c
> > @@ -357,6 +357,7 @@ static int daemonErrorLogFilter(virErrorPtr err, int priority)
> > case VIR_ERR_NO_NWFILTER:
> > case VIR_ERR_NO_SECRET:
> > case VIR_ERR_NO_DOMAIN_SNAPSHOT:
> > + case VIR_ERR_OPERATION_INVALID:
> > return VIR_LOG_DEBUG;
> > }
>
> ACK
thanks, pushed !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel at veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
More information about the libvir-list
mailing list