[libvirt] [PATCH 1/5] daemon: avoid memory leak

[Eric Blake]

On 09/18/2011 10:36 AM, ajia at redhat.com wrote:
> * daemon/remote.c: fix memory leak.

Your commit message didn't mention which function you fixed,...

>
> Signed-off-by: Alex Jia<ajia at redhat.com>
> ---
>   daemon/remote.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/daemon/remote.c b/daemon/remote.c
> index 38bbb10..45244f8 100644
> --- a/daemon/remote.c
> +++ b/daemon/remote.c
> @@ -997,6 +997,8 @@ cleanup:

and git didn't list it either, so I had to look.  I tweaked the commit 
message to mention remoteDispatchDomainBlockStatsFlags, and that the 
leak was introduced in commit efa7fc9.

>               VIR_FREE(ret->params.params_val);
>           }
>       }
> +    if (dom)
> +        virDomainFree(dom);
>       VIR_FREE(params);
>       return rv;

ACK and pushed.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org