On 09/19/2011 10:03 PM, Daniel Veillard wrote:
* daemon/remote.c: fix string allocations and memory error handling for remoteRelayDomainEventBlockJob, remoteRelayDomainEventIOError, remoteRelayDomainEventIOErrorReason and remoteRelayDomainEventGraphics
return 0;
+mem_error:
+ virReportOOMError();
+ virFree(data.srcPath);
+ virFree(data.devAlias);
This is broken. It will make us crash on OOM. See: https://www.redhat.com/archives/libvir-list/2011-September/msg00779.html -- Eric Blake eblake redhat com +1-801-349-2682 Libvirt virtualization library http://libvirt.org