[libvirt] [PATCH] qemu: Fix shutdown regression

Dave Allan dallan at redhat.com
Tue Sep 20 19:19:10 UTC 2011


On Tue, Sep 20, 2011 at 09:10:46PM +0200, Jiri Denemark wrote:
> On Tue, Sep 20, 2011 at 19:39:15 +0200, Jiri Denemark wrote:
> > The commit that prevents disk corruption on domain shutdown
> > (96fc4784177ecb70357518fa863442455e45ad0e) causes regression with QEMU
> > 0.14.* and 0.15.* because of a regression bug in QEMU that was fixed
> > only recently in QEMU git. With affected QEMU binaries, domains cannot
> > be shutdown properly and stay in a paused state. This patch tries to
> > avoid this by sending SIGKILL to 0.1[45].* QEMU processes. Though we
> > wait a bit more between sending SIGTERM and SIGKILL to reduce the
> > possibility of virtual disk corruption.
> 
> An alternative solution would be to break reboot on affected QEMUs instead of
> trying to live with possible data corruption as if libvirt 0.9.[34] is used.
> That is, virDomainReboot would report unsupported operation because current
> emulator binary is not able to support it without causing possible data
> corruption during shutdown.

That approach gets my vote.

Dave

> Jirka
> 
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list




More information about the libvir-list mailing list