[libvirt] [PATCH v2] qemu: Fix shutdown regression with buggy qemu

[Eric Blake]

On 09/21/2011 08:06 AM, Jiri Denemark wrote:
> The commit that prevents disk corruption on domain shutdown
> (96fc4784177ecb70357518fa863442455e45ad0e) causes regression with QEMU
> 0.14.* and 0.15.* because of a regression bug in QEMU that was fixed
> only recently in QEMU git. The affected versions of QEMU do not quit on
> SIGTERM if started with -no-shutdown, which we use to implement fake
> reboot. Since -no-shutdown tells QEMU not to quit automatically on guest
> shutdown, domains started using the affected QEMU cannot be shutdown
> properly and stay in a paused state.
>
> This patch disables fake reboot feature on such QEMU by not using
> -no-shutdown, which makes shutdown work as expected. However,
> virDomainReboot will not work in this case and it will report "Requested
> operation is not valid: Reboot is not supported with this QEMU binary".
> ---
>   src/qemu/qemu_capabilities.c |    8 ++++++++
>   src/qemu/qemu_capabilities.h |    1 +
>   src/qemu/qemu_command.c      |    2 +-
>   src/qemu/qemu_driver.c       |    6 ++++++
>   4 files changed, 16 insertions(+), 1 deletions(-)

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org