[libvirt] [PATCH] qemuOpenFile: Don't force chown on NFS
Eric Blake
eblake at redhat.com
Wed Apr 11 17:37:04 UTC 2012
On 04/11/2012 08:41 AM, Eric Blake wrote:
> On 04/11/2012 03:17 AM, Michal Privoznik wrote:
>> If dynamic_ownership is off and we are creating a file on NFS
>> we force chown. This will fail as chown/chmod are not supported
>> on NFS. However, with no dynamic_ownership we are not required
>> to do any chown.
>> ---
>> src/qemu/qemu_driver.c | 10 ++++++++--
>> 1 files changed, 8 insertions(+), 2 deletions(-)
>
> ACK.
My ACK may be premature. I think we need to worry about multiple
scenarios - it is true that root-squash NFS won't allow a chown, but not
all NFS are root-squash, so this may be breaking something. I'll let
Laine chime in with a review, since he has historically had experience
with testing multiple NFS setups.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120411/3b0845bd/attachment-0001.sig>
More information about the libvir-list
mailing list