[libvirt] [PATCH 4/3] conf: Avoid double assignment in virDomainDiskRemove

Osier Yang jyang at redhat.com
Fri Apr 13 10:25:38 UTC 2012


On 04/13/2012 05:24 PM, Michal Privoznik wrote:
> Although it should be harmless to do:
>      disk = disk = def->disks[i]
> some not-so-wise compilers may fool around.
> Besides, such assignment is useless here.
> ---
>   src/conf/domain_conf.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index c6b97e1..a9c5cbc 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -7124,7 +7124,7 @@ void virDomainDiskInsertPreAlloced(virDomainDefPtr def,
>   virDomainDiskDefPtr
>   virDomainDiskRemove(virDomainDefPtr def, size_t i)
>   {
> -    virDomainDiskDefPtr disk = disk = def->disks[i];
> +    virDomainDiskDefPtr disk = def->disks[i];
>
>       if (def->ndisks>  1) {
>           memmove(def->disks + i,

ACK




More information about the libvir-list mailing list