[libvirt] [PATCH 1/2] qemu: Use common helper when probing qemu capabilities
Eric Blake
eblake at redhat.com
Thu Apr 26 16:42:36 UTC 2012
On 04/26/2012 08:28 AM, Jiri Denemark wrote:
> QEMU binary is called several times when we probe different kinds of
> capabilities the binary supports. This patch introduces new common
> helper so that all probes use a consistent way of invoking qemu.
> ---
> src/qemu/qemu_capabilities.c | 59 ++++++++++++++++++++++++++---------------
> src/qemu/qemu_capabilities.h | 5 +++
> src/qemu/qemu_driver.c | 9 +++++-
> 3 files changed, 50 insertions(+), 23 deletions(-)
Nice. Just today, I hit a bug where I wish we were caching qemu
capabilities better, and by filtering things into a common entry point,
I'm hoping it makes future edits able to take advantage of that one
location, rather than chasing down multiple callers.
https://bugzilla.redhat.com/show_bug.cgi?id=816674
At any rate, this patch looks correct:
ACK.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120426/60fac2fd/attachment-0001.sig>
More information about the libvir-list
mailing list