[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] qemu: Use common helper when probing qemu capabilities



On Thu, Apr 26, 2012 at 10:42:36 -0600, Eric Blake wrote:
> On 04/26/2012 08:28 AM, Jiri Denemark wrote:
> > QEMU binary is called several times when we probe different kinds of
> > capabilities the binary supports. This patch introduces new common
> > helper so that all probes use a consistent way of invoking qemu.
> > ---
> >  src/qemu/qemu_capabilities.c |   59 ++++++++++++++++++++++++++---------------
> >  src/qemu/qemu_capabilities.h |    5 +++
> >  src/qemu/qemu_driver.c       |    9 +++++-
> >  3 files changed, 50 insertions(+), 23 deletions(-)
> 
> Nice.  Just today, I hit a bug where I wish we were caching qemu
> capabilities better, and by filtering things into a common entry point,
> I'm hoping it makes future edits able to take advantage of that one
> location, rather than chasing down multiple callers.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=816674
> 
> At any rate, this patch looks correct:
> 
> ACK.

OK, I pushed this patch since it doesn't depend on qemu support. I'll wait
with pushing 2/2 until -no-user-config support is committed in qemu.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]