[libvirt] [libvirt-sandbox PATCH 1/2] main: Don't free error twice
Daniel P. Berrange
berrange at redhat.com
Sun Feb 26 19:11:29 UTC 2012
On Sun, Feb 26, 2012 at 01:49:33PM +0100, Guido Günther wrote:
> It's already being cleared in cleanup. Otherwise we see:
>
> Unknown option -D
> Run 'libvirt-sandbox --help' to see a full list of available command line options
> *** glibc detected *** /var/scratch/debian/libvirt-sandbox/libvirt-sandbox/bin/.libs/lt-virt-sandbox: double free or corruption (fasttop): 0x08d888b0 ***
> ======= Backtrace: =========
> /lib/i386-linux-gnu/i686/cmov/libc.so.6(+0x6e221)[0xb7255221]
> /lib/i386-linux-gnu/i686/cmov/libc.so.6(+0x6fa88)[0xb7256a88]
> /lib/i386-linux-gnu/i686/cmov/libc.so.6(cfree+0x6d)[0xb7259b3d]
> /lib/i386-linux-gnu/libglib-2.0.so.0(+0x4c38b)[0xb73c038b]
> /lib/i386-linux-gnu/i686/cmov/libc.so.6(__libc_start_main+0xe6)[0xb71fde46]
> ---
> bin/virt-sandbox.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c
> index b24b24b..00b2a29 100644
> --- a/bin/virt-sandbox.c
> +++ b/bin/virt-sandbox.c
> @@ -112,7 +112,6 @@ int main(int argc, char **argv) {
> g_printerr("%s\n%s\n",
> error->message,
> gettext(help_msg));
> - g_error_free(error);
> goto cleanup;
> }
ACK,
don't forget to add yourself to AUTHORS when pushing, so that
'make syntax-check' still passes
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list