[libvirt] [PATCH] Add support for disabling S3 and S4 states
Daniel P. Berrange
berrange at redhat.com
Mon Jul 30 12:33:55 UTC 2012
On Mon, Jul 30, 2012 at 02:25:04PM +0200, Martin Kletzander wrote:
> There a two new elements in <features> implemented, which control what
> ACPI sleeping states will be advertised. The default is to have both
> states enabled, so this means no change for current machines.
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index b7562ad..859cb26 100644
> --- a/docs/schemas/domaincommon.rng
> +++ b/docs/schemas/domaincommon.rng
> @@ -2788,6 +2788,16 @@
> <empty/>
> </element>
> </optional>
> + <optional>
> + <element name="disable_s3">
> + <empty/>
> + </element>
> + </optional>
> + <optional>
> + <element name="disable_s4">
> + <empty/>
> + </element>
> + </optional>
> </interleave>
> </element>
> </optional>
This is not very nice design. With this if an app wants to request
S3, and have an error if it is not supported, they can't do that.
I think we need a tri-state for S3/S4
- Default (hypervisor-specific)
- On
- Off
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list