[libvirt] [PATCH] util: remove unneeded #include in virrandom.c

Laine Stump laine at laine.org
Thu Mar 1 16:43:04 UTC 2012


Commit 7c90026 added #include "conf/domain_conf.h" to
util/virrandom.c. Fortunately it didn't actually use anything from
domain_conf.h, since as far as I'm aware, files in util aren't allowed
to reference anything in conf (although the opposite is allowed). So
this #include is unnecessary.

I verified it still compiles with the line removed, but have placed a
one day moratorium on me doing any "trivial rule" pushes, so will
wait for someone else to verify/ACK before pushing.
---
 src/util/virrandom.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/util/virrandom.c b/src/util/virrandom.c
index 151cf4b..9092fd2 100644
--- a/src/util/virrandom.c
+++ b/src/util/virrandom.c
@@ -29,7 +29,6 @@
 #include "count-one-bits.h"
 #include "util.h"
 #include "virterror_internal.h"
-#include "conf/domain_conf.h"
 
 #define VIR_FROM_THIS VIR_FROM_NONE
 
-- 
1.7.7.6




More information about the libvir-list mailing list