[libvirt] [PATCH] Cpu mapping cleanup
Martin Kletzander
mkletzan at redhat.com
Mon Mar 19 18:35:21 UTC 2012
On 03/19/2012 06:10 PM, Eric Blake wrote:
> On 03/19/2012 06:29 AM, Martin Kletzander wrote:
>> Using inheritance, this patch cleans up the cpu_map.xml file and also
>> sorts all CPU features according to the feature and registry
>> values. Model features are sorted the same way as foeatures in the
>
> s/foeatures/features/
>
>> specification.
>> Also few models that are related were organized together and parts of
>> the XML are marked with comments
>> ---
>> src/cpu/cpu_map.xml | 455 +++++++++-----------------------------------------
>> 1 files changed, 82 insertions(+), 373 deletions(-)
>
> The inheritance is definitely an improvement for reducing lines of code.
> The patch was a bit hard to read (splitting things into three patches:
> reordering options, reordering CPU models into groups, then taking
> advantage of inheritance; rather than doing all three actions in one
> patch, might have been easier), but seems correct after the few minutes
> I've spent on it, and isn't worth the time to respin the series just to
> split the patch.
I was thinking how to split the patch and this variant didn't cross my
mind. Definitely next time =)
>
> ACK.
>
Could you also push it, please (I don't have permissions for that)?
Thanks
More information about the libvir-list
mailing list