[libvirt] [test-API PATCH 1/7] utils: Make ipget.sh more portable
Osier Yang
jyang at redhat.com
Wed Mar 21 14:26:37 UTC 2012
On 2012年03月21日 20:46, Peter Krempa wrote:
> Change the test for existence of nmap to be a little more cross-distro
> portable.
> ---
> utils/ipget.sh | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/utils/ipget.sh b/utils/ipget.sh
> index cc1949b..4e6b3dd 100755
> --- a/utils/ipget.sh
> +++ b/utils/ipget.sh
> @@ -6,8 +6,8 @@ if [[ -z $mac ]]; then
> exit 1
> fi
>
> -if ! rpm -qa |grep -q nmap ;then
> - echo "need nmap rpmball installed."
> +if ! which nmap> /dev/null; then
> + echo "nmap package needs to be installed."
> exit 1
> fi
>
Make sense, and ACK.
More information about the libvir-list
mailing list