[libvirt] [PATCH v2 1/1] qemu, util: on restart of libvirt restart vepa callbacks

[D. Herrendoerfer]

On Mar 23, 2012, at 7:21 PM, Laine Stump wrote:

>
> Related to this patch - while looking at the uses of
> virNetDevVPortProfileAssociate(), I found the function
> qemuMigrationVPAssociatePortProfiles() in src/qemu/qemu_migration.c.  
> It
> calls virNetDevVPortProfileAssociate() without ever calling
> virNetDevMacVLanVPortProfileRegisterCallback(). I'm wondering if  
> either
> 1) the normal setup of port profiles (is
> virNetDevMacVLanCreateWithVPortProfile) is missed during migration,  
> and
> this function needs to be changed/enhanced, or 2) this associate is
> redundant. I don't have the hardware to test either a migration *or*
> vepa mode, but this seems like something important to determine (and  
> fix
> if it's broken).

I'm currently looking at migration, and I will follow this up ASAP,  
because
of the complication of having to go through pre-association there are  
2 calls
to virNetDevVPortProfileAssociate() and only when migration has  
completed
successfully the callback should be registered.

The combined patches check out ok, but I haven't covered all tests yet.

DirkH
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120327/798fc27e/attachment-0001.htm>