[libvirt] [PATCHv2 1/4] nodeinfo: drop static variable

Stefan Berger stefanb at linux.vnet.ibm.com
Sat May 12 01:25:33 UTC 2012


On 05/11/2012 06:41 PM, Eric Blake wrote:
> We were wasting time to malloc a copy of a constant string, then
> copy it into static storage, for every call to nodeGetInfo.  At
> least we were lucky that it was a constant source, and thus not
> subject to even worse issues with one thread clobbering the static
> storage while another was using it.  This gets rid of the waste,
> by passing the string through the stack instead, as well as renaming
> internal functions to better match our conventions.

ACK




More information about the libvir-list mailing list