Re: [libvirt] [snmp PATCH 2/2] Stop event thread on server stop

[Michal Privoznik <mprivozn redhat com>]

On 30.05.2012 15:29, Martin Kletzander wrote:
> When C-c is sent to the process, the main thread (server) receives it
> and sets keep_running to 0, but the second thread is still
> running. Also, the second thread is not cleaned up after
> pthread_join() or pthread_destroy().
> This patch adds the cleanup function before all exit points of the
> program and fixes the cleansing of the second thread.
> ---

Okay, I see your point.
>  src/libvirtMib_subagent.c |    4 +++-
>  src/libvirtSnmp.c         |   20 +++++++++++++++++++-

However, libvirtMib_subagent.c is generated file (not compile time, but
MIB change time). One day I'll rewrite this. But till then:

ACK to this.

Michal