[libvirt] [PATCH] vmware: set the driver version

[Eric Blake]

On 04/08/2014 10:01 AM, Jean-Baptiste Rouault wrote:
> Since commit 7457cbe8 the vmware driver version isn't set anymore.
> ---
>  src/vmware/vmware_conf.c | 1 +
>  1 file changed, 1 insertion(+)
> 

Good catch, but it could be even simpler to skip the temporary variable.
 I'll push in your name, since you found the issue:

diff --git i/src/vmware/vmware_conf.c w/src/vmware/vmware_conf.c
index 6aba4f8..5ff6396 100644
--- i/src/vmware/vmware_conf.c
+++ w/src/vmware/vmware_conf.c
@@ -259,7 +259,6 @@ vmwareParseVersionStr(int type, const char *verbuf,
unsigned long *version)
 int
 vmwareExtractVersion(struct vmware_driver *driver)
 {
-    unsigned long version = 0;
     int ret = -1;
     virCommandPtr cmd = NULL;
     char * outbuf = NULL;
@@ -298,7 +297,7 @@ vmwareExtractVersion(struct vmware_driver *driver)
     if (virCommandRun(cmd, NULL) < 0)
         goto cleanup;

-    if (vmwareParseVersionStr(driver->type, outbuf, &version) < 0)
+    if (vmwareParseVersionStr(driver->type, outbuf, &driver->version) < 0)
         goto cleanup;

     ret = 0;


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140408/fad26661/attachment-0001.sig>