[libvirt] [PATCH 2/2] util: Add tests for scsi utils
Eric Blake
eblake at redhat.com
Wed Jan 29 19:35:52 UTC 2014
On 01/29/2014 10:22 AM, Osier Yang wrote:
> To support to pass the path of the test data to the utils, one
s/to pass/passing/
> more argument is added to virSCSIDeviceGetSgName,
> virSCSIDeviceGetDevName, and virSCSIDeviceNew, and the related
> code is changed accordingly.
>
> Signed-off-by: Osier Yang <jyang at redhat.com>
> ---
> src/qemu/qemu_cgroup.c | 3 +-
> src/qemu/qemu_command.c | 3 +-
> src/qemu/qemu_command.h | 3 +-
> src/qemu/qemu_conf.c | 12 ++-
> src/qemu/qemu_hostdev.c | 9 +-
> src/security/security_apparmor.c | 3 +-
> src/security/security_dac.c | 6 +-
> src/security/security_selinux.c | 6 +-
> src/util/virscsi.c | 26 +++---
> src/util/virscsi.h | 9 +-
> tests/Makefile.am | 14 +++
> tests/testutilsqemu.c | 3 +-
> tests/virscsitest.c | 188 +++++++++++++++++++++++++++++++++++++++
It might be worth splitting this into two patches - one that adds the
argument and adjusts existing callers, and the other that adds the new
testsuite addition.
ACK with that split.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140129/045b1925/attachment-0001.sig>
More information about the libvir-list
mailing list