[libvirt] [PATCH] libxl: Resove Coverity dead_error_begin
Eric Blake
eblake at redhat.com
Fri Jan 31 17:23:41 UTC 2014
On 01/31/2014 10:11 AM, John Ferlan wrote:
>>>
>>> + /* coverity[dead_error_begin] */
>>> default:
>>> break;
>>> }
>>>
>>
>> Why not just delete the label instead; then you don't need a Coverity
>> marker?
>>
>
> So are you advocating for removal of the other [dead_error_begin]
> conditions in the same manner?
>
> see src/lxc/lxc_driver.c (3 occurrences) and src/nodeinfo.c (1 occurrence).
Sure - it's fewer lines of code, with no semantic difference, and with
no static checker warning.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140131/d8f67c92/attachment-0001.sig>
More information about the libvir-list
mailing list