[libvirt] [PATCH v4 2/3] qemu: extract common PCI handling functions
Roman Bogorodskiy
bogorodskiy at gmail.com
Tue May 13 17:04:48 UTC 2014
Ján Tomko wrote:
> On 05/11/2014 08:48 AM, Roman Bogorodskiy wrote:
> > Move sharable PCI handling functions to domain_addr.[ch], and
> > change theirs prefix from 'qemu' to 'vir':
> >
> > - virDomainPCIAddressAsString;
> > - virDomainPCIAddressBusSetModel;
> > - virDomainPCIAddressEnsureAddr;
> > - virDomainPCIAddressFlagsCompatible;
> > - virDomainPCIAddressGetNextSlot;
> > - virDomainPCIAddressReleaseSlot;
> > - virDomainPCIAddressReserveAddr;
> > - virDomainPCIAddressReserveNextSlot;
> > - virDomainPCIAddressReserveSlot;
> > - virDomainPCIAddressSetFree;
> > - virDomainPCIAddressSetGrow;
> > - virDomainPCIAddressSlotInUse;
> > - virDomainPCIAddressValidate;
> >
> > The only change here is function names, the implementation itself
> > stays untouched.
> >
> > Extract common allocation code from DomainPCIAddressSetCreate
> > into virDomainPCIAddressSetAlloc.
>
> Unrelated whitespace change.
>
> ACK with the ATTRIBUTE_NONNULL removed for model.
Pushed 1/3 and 2/3 with the fixes applied; thanks.
Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140513/35b1e571/attachment-0001.sig>
More information about the libvir-list
mailing list