[libvirt] [PATCH] bhyve: fix virObjectUnlock() usage
Eric Blake
eblake at redhat.com
Mon May 19 16:45:41 UTC 2014
On 05/17/2014 01:44 PM, Roman Bogorodskiy wrote:
> In a number of places in the bhyve driver, virObjectUnlock()
> is called with an arg without check if the arg is non-NULL, which
> could result in passing NULL value and a warning like:
>
> virObjectUnlock:340 : Object 0x0 ((unknown)) is not a virObjectLockable instance
Doesn't this instead argue that we should fix virObjectUnlock to
gracefully handle a NULL parameter, rather than making every caller uglier?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140519/35257a5e/attachment-0001.sig>
More information about the libvir-list
mailing list