[libvirt] [PATCH] bhyve: fix virObjectUnlock() usage

Roman Bogorodskiy bogorodskiy at gmail.com
Mon May 19 17:26:20 UTC 2014


  Eric Blake wrote:

> > BTW, that's going to be a vast change, quick grep shows more than 750
> > calls of that function. 
> 
> It doesn't invalidate any existing caller to make virObjectUnlock()
> special-case NULL.  And while it DOES make any existing caller that also
> checks for NULL be a case of redundant code, we don't have to clean all
> callers up in a single patch.

Good, so I'll add a check for NULL in virObjectUnlock() and prepare a
series that cleans up the redundant if (obj) check before calling
virObjectUnlock(obj), say, on per-driver basis.

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140519/b18b19c8/attachment-0001.sig>


More information about the libvir-list mailing list