[libvirt] [PATCH] Remove unsupported type sdl from error info when set 2 vnc or spice graphics

[Daniel P. Berrange]

On Fri, May 23, 2014 at 11:31:17AM +0200, Peter Krempa wrote:
> On 05/23/14 11:26, Daniel P. Berrange wrote:
> > On Fri, May 23, 2014 at 05:23:36PM +0800, tzheng at redhat.com wrote:
> >> ---
> >>  src/qemu/qemu_command.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> >> index 193959f..a146463 100644
> >> --- a/src/qemu/qemu_command.c
> >> +++ b/src/qemu/qemu_command.c
> >> @@ -8579,7 +8579,7 @@ qemuBuildCommandLine(virConnectPtr conn,
> >>      if (sdl > 1 || vnc > 1 || spice > 1) {
> >>          virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> >>                         _("only 1 graphics device of each type "
> >> -                         "(sdl, vnc, spice) is supported"));
> >> +                         "(vnc, spice) is supported"));
> >>          goto error;
> >>      }
> > 
> > What makes you think SDL is unsupported ?
> > 
> 
> It's unsupported in rhel-7 (
> https://bugzilla.redhat.com/show_bug.cgi?id=1100634 ). Upstream we do
> support it.

Even that's wrong. The KVM binary shipped in RHEL doesn't support it,
but libvirt does support it. The user may be using libvirt with a
different QEMU/KVM binary than the one we expect - eg a newer version
shipped by a software collection or RHEL add-on like RDO


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|