[libvirt] [PATCH] util: storage: Fix crash of libvirtd on network backed guest block-pull

Peter Krempa pkrempa at redhat.com
Thu May 29 15:04:49 UTC 2014


On 05/29/14 16:58, Eric Blake wrote:
> On 05/29/2014 08:52 AM, Peter Krempa wrote:
>> For guests backed by gluster volumes (or other network storage) we don't
>> fill the backing chain (see qemuDomainDetermineDiskChain). This leaves
>> the "relPath" field of the top image NULL. This causes a crash in
>> virStorageFileChainLookup() when looking up a backing element for such a
>> disk.
>>
>> Since I'm working on adding support for network storage and one of the
>> steps will make the "relPath" field optional let's use STREQ_NULLABLE
>> instead of STREQ in virStorageFileChainLookup() to avoid the problem.
>> ---
>>  src/util/virstoragefile.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> ACK, safe for 1.2.5.
> 

Pushed; Thanks.

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140529/6af4c1fe/attachment-0001.sig>


More information about the libvir-list mailing list