[libvirt] [PATCH] conf: Fix invalid pointer check in virDomainObjGetDefs

Peter Krempa pkrempa at redhat.com
Thu Jun 4 11:28:54 UTC 2015


Coverity rightfully determined that in commit 3d021381c71221e563182f03
I made a mistake in the first check if @persDef is not NULL is
dereferencing it rather than checking.
---

Pushed as trivial.

 src/conf/domain_conf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 77e198c..68d28f6 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -2927,7 +2927,7 @@ virDomainObjGetDefs(virDomainObjPtr vm,
     if (liveDef)
         *liveDef = NULL;

-    if (*persDef)
+    if (persDef)
         *persDef = NULL;

     if (virDomainObjUpdateModificationImpact(vm, &flags) < 0)
-- 
2.4.1




More information about the libvir-list mailing list