[libvirt] [PATCH 0/2] Adjust netfs CIFS/Samba formatting

John Ferlan jferlan at redhat.com
Mon Jun 15 19:04:47 UTC 2015



On 06/03/2015 01:06 PM, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1186969
> 
> The first patch follows a previous change to fix/adjust the gluster
> specific rng formatting
> 
> The second patch resolves the particular issue ensuring to generate the
> source path with the "//%s/%s" instead of "%s:%s" and with the "-o group"
> to connect to the Samba serbver.
> 
> John Ferlan (2):
>   storage: Fix the schema and add tests for cifs pool
>   storage: Generate correct parameters for CIFS
> 
>  docs/formatstorage.html.in                      |  7 ++++--
>  docs/schemas/storagepool.rng                    | 24 +++++++++++++++++++-
>  docs/storage.html.in                            |  3 ++-
>  src/storage/storage_backend_fs.c                | 29 ++++++++++++++++++++-----
>  tests/storagepoolxml2xmlin/pool-netfs-cifs.xml  | 12 ++++++++++
>  tests/storagepoolxml2xmlout/pool-netfs-cifs.xml | 15 +++++++++++++
>  tests/storagepoolxml2xmltest.c                  |  1 +
>  7 files changed, 82 insertions(+), 9 deletions(-)
>  create mode 100644 tests/storagepoolxml2xmlin/pool-netfs-cifs.xml
>  create mode 100644 tests/storagepoolxml2xmlout/pool-netfs-cifs.xml
> 

Ping... I know... Samba/Windows... no one's complained it's broken from
day 1...

Thanks -

John




More information about the libvir-list mailing list