[libvirt] [PATCH] Introduce virBitmapIsBitSet

Martin Kletzander mkletzan at redhat.com
Thu Mar 12 07:29:31 UTC 2015


On Wed, Mar 11, 2015 at 07:34:22PM +0100, Ján Tomko wrote:
>A helper that never returns an error and treats bits out of bitmap range
>as false.
>
>Use it everywhere we use ignore_value on virBitmapGetBit, or loop over
>the bitmap size.
>---
> src/conf/domain_conf.c        |  4 +---
> src/conf/node_device_conf.c   |  4 +---
> src/conf/snapshot_conf.c      |  6 ++----
> src/conf/storage_conf.c       |  4 +---
> src/libvirt_private.syms      |  1 +
> src/libxl/libxl_domain.c      |  4 +---
> src/libxl/libxl_driver.c      |  5 +----
> src/nodeinfo.c                |  6 +-----
> src/qemu/qemu_capabilities.c  |  7 +------
> src/storage/storage_backend.c |  4 +---
> src/util/virbitmap.c          | 18 ++++++++++++++++++
> src/util/virbitmap.h          |  5 +++++
> src/util/vircgroup.c          |  4 +---
> src/util/virdnsmasq.c         |  6 +-----
> src/util/virportallocator.c   | 17 +++--------------
> src/util/virprocess.c         |  9 ++-------
> src/xen/xen_driver.c          |  4 +---
> src/xen/xend_internal.c       |  5 +----
> 18 files changed, 43 insertions(+), 70 deletions(-)
>

Nice cleanup, ACK.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150312/4d03652a/attachment-0001.sig>


More information about the libvir-list mailing list