[libvirt] [PATCH 0/3] Introduce new virtType enum item

John Ferlan jferlan at redhat.com
Wed Sep 23 23:26:57 UTC 2015



On 09/23/2015 12:51 AM, Shivangi Dhir wrote:

[...]


> 
> Thanks alot for your feedback.
> Should I modify and resend the patches after making the changes
> suggested above, if there are no other issues ?
> 
> 

I should be able to jiggle your patches - I'll work on those tomorrow
(for me).

I also found out from practice that using virDomainVirtType in the
capabilities.{h,c} functions & structures would result in many more
changes in order to pull in the definition from domain_conf.h.  So just
kept them as int, but added a comment to make it more obvious.

I'll end up with two patches, with the first getting the attached
squashed in... Unless someone comes up with a path that's using the
numerical representation - it just seemed the virtType would be (but I
can check that).


John

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-merge.patch
Type: text/x-patch
Size: 3474 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150923/adad2d9f/attachment-0001.bin>


More information about the libvir-list mailing list