[libvirt] [PATCH tck v2 5/5] 240-no-arp-spoofing.t: get virt-builder install dsniff

[Cédric Bosdonnat]

We can't be sure the guest will have yum installed as package manager.
Thus delegate the dsniff package install to virt-builder as it provides
an abstraction for that.
---
 lib/Sys/Virt/TCK.pm                    | 2 +-
 scripts/nwfilter/240-no-arp-spoofing.t | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/Sys/Virt/TCK.pm b/lib/Sys/Virt/TCK.pm
index f6fce93..5d9378d 100644
--- a/lib/Sys/Virt/TCK.pm
+++ b/lib/Sys/Virt/TCK.pm
@@ -405,7 +405,7 @@ sub create_virt_builder_disk {
     }
 
     print "# running virt-builder $osname\n";
-    `virt-builder --root-password 'password:$password' --output $target $osname`;
+    `virt-builder --install dsniff --root-password 'password:$password' --output $target $osname`;
 
     return $target;
 }
diff --git a/scripts/nwfilter/240-no-arp-spoofing.t b/scripts/nwfilter/240-no-arp-spoofing.t
index 6b346aa..284033d 100644
--- a/scripts/nwfilter/240-no-arp-spoofing.t
+++ b/scripts/nwfilter/240-no-arp-spoofing.t
@@ -92,7 +92,6 @@ $ssh->login("root", $tck->root_password());
 # now generate a arp spoofing packets 
 diag "generate arpspoof";
 my $cmdfile = <<EOF;
-echo '/usr/bin/yum -y install dsniff
 /usr/sbin/arpspoof ${spoofid} &
 /bin/sleep 10
 kill -15 `/sbin/pidof arpspoof`' > /test.sh
-- 
2.1.4