[libvirt] [PATCH v1 18/19] conf: Do not create a virtio-scsi controller for vhost-scsi hostdev

Eric Farman farman at linux.vnet.ibm.com
Mon Jul 25 20:48:19 UTC 2016


The idea of vhost-scsi is to have a controller-less host device that
carries all LUNs, so (silently) creating a virtio-scsi controller is
not necessary here.  Let's get adjust the comparison so we don't
accidentally make one.

Signed-off-by: Eric Farman <farman at linux.vnet.ibm.com>
Reviewed-by: Bjoern Walk <bwalk at linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiuczy at linux.vnet.ibm.com>
---
 src/conf/domain_conf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 8d6d208..1768292 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -15401,6 +15401,7 @@ virDomainDefMaybeAddHostdevSCSIcontroller(virDomainDefPtr def)
         hostdev = def->hostdevs[i];
         if (hostdev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS &&
             hostdev->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI &&
+            hostdev->source.subsys.u.scsi.protocol != VIR_DOMAIN_HOSTDEV_SCSI_PROTOCOL_TYPE_VHOST &&
             (int)hostdev->info->addr.drive.controller > maxController) {
             maxController = hostdev->info->addr.drive.controller;
         }
-- 
1.9.1




More information about the libvir-list mailing list