[libvirt] [PATCH 1/5] vz: don't pass empty and unused fields in migration cookie
Nikolay Shirokovskiy
nshirokovskiy at virtuozzo.com
Wed Jun 8 07:17:19 UTC 2016
The first version of migration cookie was rather dumb resulting
in passing empty or unused fields here and there. Add flags to
specify what to bake to and eat from cookie so we deal only
with meaningful data. However for backwards compatibility
we still need to pass at least some faked fields sometimes.
Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy at virtuozzo.com>
---
src/vz/vz_driver.c | 109 +++++++++++++++++++++++++++++++++--------------------
1 file changed, 68 insertions(+), 41 deletions(-)
diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c
index 177a57a..a404666 100644
--- a/src/vz/vz_driver.c
+++ b/src/vz/vz_driver.c
@@ -2103,11 +2103,17 @@ vzDomainRevertToSnapshot(virDomainSnapshotPtr snapshot, unsigned int flags)
return ret;
}
+enum vzMigrationCookieFeatures {
+ VZ_MIGRATION_COOKIE_SESSION_UUID = (1 << 0),
+ VZ_MIGRATION_COOKIE_DOMAIN_UUID = (1 << 1),
+ VZ_MIGRATION_COOKIE_DOMAIN_NAME = (1 << 1),
+};
+
typedef struct _vzMigrationCookie vzMigrationCookie;
typedef vzMigrationCookie *vzMigrationCookiePtr;
struct _vzMigrationCookie {
- unsigned char session_uuid[VIR_UUID_BUFLEN];
- unsigned char uuid[VIR_UUID_BUFLEN];
+ unsigned char *session_uuid;
+ unsigned char *uuid;
char *name;
};
@@ -2116,12 +2122,18 @@ vzMigrationCookieFree(vzMigrationCookiePtr mig)
{
if (!mig)
return;
+
+ VIR_FREE(mig->session_uuid);
+ VIR_FREE(mig->uuid);
VIR_FREE(mig->name);
VIR_FREE(mig);
}
static int
-vzBakeCookie(vzMigrationCookiePtr mig, char **cookieout, int *cookieoutlen)
+vzBakeCookie(vzDriverPtr driver,
+ virDomainObjPtr dom,
+ char **cookieout, int *cookieoutlen,
+ unsigned int flags)
{
char uuidstr[VIR_UUID_STRING_BUFLEN];
virBuffer buf = VIR_BUFFER_INITIALIZER;
@@ -2137,11 +2149,28 @@ vzBakeCookie(vzMigrationCookiePtr mig, char **cookieout, int *cookieoutlen)
virBufferAddLit(&buf, "<vz-migration>\n");
virBufferAdjustIndent(&buf, 2);
- virUUIDFormat(mig->session_uuid, uuidstr);
- virBufferAsprintf(&buf, "<session-uuid>%s</session-uuid>\n", uuidstr);
- virUUIDFormat(mig->uuid, uuidstr);
- virBufferAsprintf(&buf, "<uuid>%s</uuid>\n", uuidstr);
- virBufferAsprintf(&buf, "<name>%s</name>\n", mig->name);
+
+ if (flags & VZ_MIGRATION_COOKIE_SESSION_UUID) {
+ virUUIDFormat(driver->session_uuid, uuidstr);
+ virBufferAsprintf(&buf, "<session-uuid>%s</session-uuid>\n", uuidstr);
+ }
+
+ if (flags & VZ_MIGRATION_COOKIE_DOMAIN_UUID) {
+ unsigned char fakeuuid[VIR_UUID_BUFLEN] = { 0 };
+
+ /* if dom is NULL just pass some parsable uuid for backward compat.
+ * It is not used by peer */
+ virUUIDFormat(dom ? dom->def->uuid : fakeuuid, uuidstr);
+ virBufferAsprintf(&buf, "<uuid>%s</uuid>\n", uuidstr);
+ }
+
+ if (flags & VZ_MIGRATION_COOKIE_DOMAIN_NAME) {
+ /* if dom is NULL just pass some name for backward compat.
+ * It is not used by peer */
+ virBufferAsprintf(&buf, "<name>%s</name>\n", dom ? dom->def->name :
+ "__fakename__");
+ }
+
virBufferAdjustIndent(&buf, -2);
virBufferAddLit(&buf, "</vz-migration>\n");
@@ -2155,11 +2184,11 @@ vzBakeCookie(vzMigrationCookiePtr mig, char **cookieout, int *cookieoutlen)
}
static vzMigrationCookiePtr
-vzEatCookie(const char *cookiein, int cookieinlen)
+vzEatCookie(const char *cookiein, int cookieinlen, unsigned int flags)
{
xmlDocPtr doc = NULL;
xmlXPathContextPtr ctx = NULL;
- char *tmp;
+ char *tmp = NULL;
vzMigrationCookiePtr mig = NULL;
if (VIR_ALLOC(mig) < 0)
@@ -2175,33 +2204,31 @@ vzEatCookie(const char *cookiein, int cookieinlen)
_("(_migration_cookie)"), &ctx)))
goto error;
- if (!(tmp = virXPathString("string(./session-uuid[1])", ctx))) {
+ if ((flags & VZ_MIGRATION_COOKIE_SESSION_UUID)
+ && (!(tmp = virXPathString("string(./session-uuid[1])", ctx))
+ || (VIR_ALLOC_N(mig->session_uuid, VIR_UUID_BUFLEN) < 0)
+ || (virUUIDParse(tmp, mig->session_uuid) < 0))) {
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
- _("missing session-uuid element in migration data"));
- goto error;
- }
- if (virUUIDParse(tmp, mig->session_uuid) < 0) {
- virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
- _("malformed session-uuid element in migration data"));
+ _("missing or malformed session-uuid element "
+ "in migration data"));
VIR_FREE(tmp);
goto error;
}
VIR_FREE(tmp);
- if (!(tmp = virXPathString("string(./uuid[1])", ctx))) {
- virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
- _("missing uuid element in migration data"));
- goto error;
- }
- if (virUUIDParse(tmp, mig->uuid) < 0) {
+ if ((flags & VZ_MIGRATION_COOKIE_DOMAIN_UUID)
+ && (!(tmp = virXPathString("string(./uuid[1])", ctx))
+ || (VIR_ALLOC_N(mig->uuid, VIR_UUID_BUFLEN) < 0)
+ || (virUUIDParse(tmp, mig->uuid) < 0))) {
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
- _("malformed uuid element in migration data"));
+ _("missing or malformed uuid element in migration data"));
VIR_FREE(tmp);
goto error;
}
VIR_FREE(tmp);
- if (!(mig->name = virXPathString("string(./name[1])", ctx))) {
+ if ((flags & VZ_MIGRATION_COOKIE_DOMAIN_NAME)
+ && !(mig->name = virXPathString("string(./name[1])", ctx))) {
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
_("missing name element in migration data"));
goto error;
@@ -2238,7 +2265,6 @@ vzDomainMigrateBegin3Params(virDomainPtr domain,
char *xml = NULL;
virDomainObjPtr dom = NULL;
vzConnPtr privconn = domain->conn->privateData;
- vzMigrationCookiePtr mig = NULL;
virCheckFlags(VZ_MIGRATION_FLAGS, NULL);
@@ -2257,15 +2283,11 @@ vzDomainMigrateBegin3Params(virDomainPtr domain,
if (!(dom = vzDomObjFromDomain(domain)))
goto cleanup;
- if (VIR_ALLOC(mig) < 0)
- goto cleanup;
-
- if (VIR_STRDUP(mig->name, dom->def->name) < 0)
- goto cleanup;
-
- memcpy(mig->uuid, dom->def->uuid, VIR_UUID_BUFLEN);
-
- if (vzBakeCookie(mig, cookieout, cookieoutlen) < 0)
+ /* session uuid is for backward compat */
+ if (vzBakeCookie(privconn->driver, dom, cookieout, cookieoutlen,
+ VZ_MIGRATION_COOKIE_SESSION_UUID
+ | VZ_MIGRATION_COOKIE_DOMAIN_UUID
+ | VZ_MIGRATION_COOKIE_DOMAIN_NAME) < 0)
goto cleanup;
xml = virDomainDefFormat(dom->def, privconn->driver->caps,
@@ -2273,7 +2295,6 @@ vzDomainMigrateBegin3Params(virDomainPtr domain,
cleanup:
- vzMigrationCookieFree(mig);
if (dom)
virObjectUnlock(dom);
return xml;
@@ -2337,12 +2358,17 @@ vzDomainMigratePrepare3Params(virConnectPtr conn,
if (!miguri && !(*uri_out = vzMigrationCreateURI()))
goto cleanup;
- if (!(mig = vzEatCookie(cookiein, cookieinlen)))
+ if (!(mig = vzEatCookie(cookiein, cookieinlen,
+ VZ_MIGRATION_COOKIE_DOMAIN_UUID
+ | VZ_MIGRATION_COOKIE_DOMAIN_NAME)))
goto cleanup;
- memcpy(mig->session_uuid, privconn->driver->session_uuid, VIR_UUID_BUFLEN);
-
- if (vzBakeCookie(mig, cookieout, cookieoutlen) < 0)
+ /* domain uuid and domain name are for backward compat */
+ if (vzBakeCookie(privconn->driver, NULL,
+ cookieout, cookieoutlen,
+ VZ_MIGRATION_COOKIE_SESSION_UUID
+ | VZ_MIGRATION_COOKIE_DOMAIN_UUID
+ | VZ_MIGRATION_COOKIE_DOMAIN_NAME) < 0)
goto cleanup;
virObjectLock(privconn->driver);
@@ -2453,7 +2479,8 @@ vzDomainMigratePerformStep(virDomainPtr domain,
goto cleanup;
}
- if (!(mig = vzEatCookie(cookiein, cookieinlen)))
+ if (!(mig = vzEatCookie(cookiein, cookieinlen,
+ VZ_MIGRATION_COOKIE_SESSION_UUID)))
goto cleanup;
if (!(dom = vzDomObjFromDomain(domain)))
--
1.8.3.1
More information about the libvir-list
mailing list