Re: [Linux-cluster] zero vote node with cman

[Olivier Crete <ocrete max-t com>]

On Fri, 2005-19-08 at 08:19 +0100, Patrick Caulfield wrote:
> Olivier Crete wrote:
> > Hi,
> > 
> > We're using cman from the STABLE branch and we're pretty satisfied.. But
> > there is one thing that I dont seem to be able to get working. In a
> > client-server application, I would like the client nodes to be able to
> > take actions when the system becomes inquorate or a server dies, but not
> > could towards the quorum.
> > 
> > I tried setting the votes to 0, but it seems that it wont let me do it..
> > Is there another solution?
> > 
> > 
> 
> It seems to be a bug in cman_tool that's overriding the votes rather
> over-enthusiastically.
> 
> This patch should fix:

Actually it doesnt.. it sets the default to 0... the attached patch
seems to work better. 


-- 
Olivier Crête
ocrete max-t com
Maximum Throughput Inc.

Index: main.c
===================================================================
RCS file: /cvs/cluster/cluster/cman/cman_tool/main.c,v
retrieving revision 1.12.2.7
diff -u -r1.12.2.7 main.c
--- main.c	21 Mar 2005 16:17:06 -0000	1.12.2.7
+++ main.c	19 Aug 2005 15:50:18 -0000
@@ -552,7 +552,7 @@
 	if (!comline->clustername[0])
 		die("cluster name not set");
 
-	if (!comline->votes)
+	if (comline->votes == -1)
 		comline->votes = DEFAULT_VOTES;
 
 	if (!comline->port)
@@ -617,6 +617,7 @@
 	prog_name = argv[0];
 
 	memset(&comline, 0, sizeof(commandline_t));
+	comline.votes = -1;
 
 	decode_arguments(argc, argv, &comline);