Re: [Linux-cluster] dlm spinlock BUG

[Patrick Caulfield <pcaulfie redhat com>]

Jens Beyer wrote:
> On Tue, Apr 17, 2007 at 03:51:53PM +0100, Patrick Caulfield wrote:
>
> I am using a vanilla 2.6.20.6 (same with 2.6.20.x).
> 

Hmm, I'm not sure how that got left unfixed upstream

Here's the patch:

-- 
Patrick

Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street,
Windsor, Berkshire, SL4 ITE, UK.
Registered in England and Wales under Company Registration No. 3798903

--- fs/dlm/lowcomms-tcp.orig	2007-04-18 16:01:18.000000000 +0100
+++ fs/dlm/lowcomms-tcp.c	2007-04-18 16:00:52.000000000 +0100
@@ -709,6 +709,7 @@ void *dlm_lowcomms_get_buffer(int nodeid
 	if (!con)
 		return NULL;
 
+	spin_lock(&con->writequeue_lock);
 	e = list_entry(con->writequeue.prev, struct writequeue_entry, list);
 	if ((&e->list == &con->writequeue) ||
 	    (PAGE_CACHE_SIZE - e->end < len)) {