[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [linux-lvm] Using Oracle with lvm AND rawio: read(512) from



"Michael Ju. Tokarev" wrote:
> 
[]
> I see in linux/include/linux/lvm.h :
> 
>  [...]
>  #ifdef BLOCK_SIZE
>  #undef BLOCK_SIZE
>  #endif
> 
>  #ifdef CONFIG_ARCH_S390
>  #define BLOCK_SIZE     4096
>  #else
>  #define BLOCK_SIZE     1024  <<<<<<<<<========
>  #endif
> 
>  #ifndef        SECTOR_SIZE
>  #define SECTOR_SIZE    512
>  #endif
>  [...]

Hm.  The same definitions are in 2.4-pre kernel patch...
So 2.4 lvm should also *not* work for 512-byte i/o size.
But Jorg de Jong claims that he successefully created
tablespace on raw dev with 2.4-pre11 kernel... I'm
confused...  And for S390 -- is smallest i/o size 4K ?!

[]
> Little *strong* suggestion.  Please rename BLOCK_SIZE
> and SECTOR_SIZE to LVM_BLOCK_SIZE and LVM_SECTOR_SIZE
> in lvm.h -- currently used names are very common to
> be a source of namespace collisions.

The same for 2.4.  Let's change those definitions while
it isn't *too* late...

Regards,
 Michael.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]