[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [linux-lvm] Debian packaging



On Wed, Dec 13, 2000 at 09:15:22PM +0100, Russell Coker wrote:
> I plan to take over the Debian package of lvm because the current maintainer 
> hasn't fixed serious bugs for quite a while.

A couple of questions.  Have you tried contacting Tom Lees <tal26 cam ac uk>?  I have talked to him and he is working on LVM 0.9 packages for sure.  Has this transfer of maintainers been approved by the powers that be at Debian yet?

> I have created packages for lvm 0.8.1 and lvm 0.9.  One change I think should 
> be done is an option for ./configure to specify whether a shared library 
> should be used or whether the programs should be statically linked.  If this 
> is desired then someone please tell me which version I should create a patch 
> against and I'll send it in.

Since the configure.in scripts are essentially the same, you can just submit a
patch to one or the other to the lvm-devel list and we'll get it in on the
next release.  I am the one responsible for the conversion of LKM to the autoconf system, so I'd be interested to see how you intend to accomplish this.

> Also as part of the Debian packaging I have put the following patch in to 
> make it clean up all files after compiling:
> diff -ruN ../LVM.orig/lvm-0.8.1.orig/Makefile.in lvm-0.8.1-0/Makefile.in
> --- ../LVM.orig/lvm-0.8.1.orig/Makefile.in      Sun Nov 12 19:52:12 2000
> +++ lvm-0.8.1-0/Makefile.in     Wed Dec 13 15:40:06 2000
> @@ -39,4 +39,5 @@
>  distclean: clean
>         $(MAKE) -C tools distclean
>         rm -f config.cache config.log config.status
> -       rm -f Makefile make.tmpl
> +       rm -f Makefile make.tmpl tools/Makefile tools/tools_and_lib.make.tmpl 
> \
> +              tools/lib/Makefile tools/man8/Makefile 
> 
> Also I have put in the following patch to work with the way Debian packages 
> have different compile and install directories:
> --- ../LVM.orig/lvm-0.8.1.orig/make.tmpl.in     Sun Nov 12 19:52:12 2000
> +++ lvm-0.8.1-0/make.tmpl.in    Wed Dec 13 15:40:06 2000
> @@ -35,11 +35,16 @@
>  # Setup directory variables
>  prefix = @prefix@
>  exec_prefix = @exec_prefix@
> -bindir = @bindir@
> -sbindir = @sbindir@
> -libdir = @libdir@
> -infodir = @infodir@
> -mandir = @mandir@
> +bindir = ${PREFIX} bindir@
> +sbindir = ${PREFIX} sbindir@
> +libdir = ${PREFIX} libdir@
> +infodir = ${PREFIX} infodir@
> +mandir = ${PREFIX} mandir@
> +
> +ifeq ($(TOP),)
> +TOP := $(shell cd `for i in . .. ../..; do if [ -f $$i/LVM-HOWTO ]; then 
> echo $$i; break; fi; done`; pwd)
> +export TOP
> +endif
>  
>  # helper scripts
>  UNINSTALL = ${TOP}/autoconf/uninstall.pl

Are you saying you want this patch applied to the upstream source?  That
really doesn't make much sense to me.  The Makefile.in patch is completely
unnecessary because the subdirectories Makefile.in files handle those
cleanups.  And it doesn't make any sense to me to put the ${PREFIX} stuff in
the upstream version, as it is not necessary.  That is what the
package.diff.gz file is created for when you build Debian packages.  That way
when you make a new version, the changes you made to the source are applied to
the new code.

> Also I would prefer to have the Debian packaging files in the upstream 
> source.  They are about 5K of data in 11 files in a separate sub-directory.  
> Please let me know if this would be desired/accepted as part of the LVM 
> upstream source and I will send the relevant patch to you.

One question.  Why?  Seems completely unnecessary to me.

Regards,
-- 
AJ Lewis
Sistina Software Inc.                  Voice:  612-379-3951
1313 5th St SE, Suite 111              Fax:    612-379-3952
Minneapolis, MN 55414                  E-Mail: lewis sistina com
Current GPG fingerprint = 3B5F 6011 5216 76A5 2F6B  52A0 941E 1261 0029 2648

No-one suspects the butterfly!

Attachment: pgp00006.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]