Re: [linux-lvm] Debian packaging

[Gergely Tamas <dice mfa kfki hu>]

Hi!

> I fixed the above and some problems of pacakges placed under
> 'ftp://ftp.sistina.com/pub/LVM/0.9/binaries/debian/'.
>
> I put this fixed pacakge under
> 'http://www.asahi-net.or.jp/~ex8k-hbn/deb/lvm/'.

Good work.

But here are some remarks to your /etc/init.d/lvm script ...

1]----
if [ ! -f /proc/lvm ]; then
	if [ ! -f /lib/modules/`uname -r`/block/lvm.o -a ! -f /lib/modules/`uname -r`/block/lvm-mod.o ]; then
		exit 0
	fi
fi
------

What if somebody compiled lvm into the kernel, not as a module? This
script doesn't work. :(

2]----
case "$1" in
	start|"")
		echo "Setting up LVM Volume Groups..."
		#/sbin/vgscan
		/sbin/vgchange -a y
		;;
------

Why did you use 'start|""' above? If run without parameters, it should
simply display a usage help.

Thanks,
Gergely