[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [linux-lvm] K=2.4.3 - LVM0.9.1.B7 compiling problem.



On Wed, Apr 25, 2001 at 03:44:13PM +0100, Joe Thornber wrote:
> >  
> >  #define lvm_fatal(x...) do {\
> >    plog(LOG_FATAL, __FILE__, __LINE__, "(FATAL) " ## x); \
> > 
> 
> If this is the right fix (time for me to download gcc 3.0) why haven't you
> changed lvm_fatal and plog ?  Does this still do the right thing under older
> versions of gcc ?

lvm_fatal I missed! plog should not be changed because the ## is needed to get
rid of the trailing comma in the instance that there is nothing in a.

It is the right fix, it only worked on older gcc because it was lenient about
the problem. ## gets rid of whitespace characters so what was happening was that
the two quoted strings were abutted eg

"error:""there was an error" - not legal C
"error:" "there was an error" - is legal C

I'll fix lvm_fatal; the only reason it fell through was that it does not get
used!

patrick



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]