Re: [linux-lvm] Bug in the min and max macros in lvm-snap.c

[Joe Thornber <thornber btconnect com>]

On Tue, Aug 28, 2001 at 05:19:09PM +0000, Jos? Luis Domingo L?pez wrote:
> On Tuesday, 28 August 2001, at 07:57:20 -0600,
> Hostmaster (www) wrote:
> 
> > Hi,
> > 
> > I'm installing the lvm_1.0.1-rc1 patch to a RedHat install (kernel 2.4.3-12).
> > 
> > After installing the kernel patch, the kernel build was failing on the min and max macros in lvm-snap.c.
> >
> Maybe I'm wrong, but AFAIR Linus changed max and min macros on 2.4.9, so
> they are not backwards compatible. As lvm_1.0.1-rc1 was intended for
> kernel 2.4.9, I suppose it used those new max/min macros, so LVM 1.0.1-rc1
> doesn't work with kernels < 2.4.9.

It should work with both 2.4.9 kernels and older ones.  I just checked
CVS and the lvm-snap.c looks correct.