[linux-lvm] kernel-Oops in 2.4.19 with LVM-1.0.5 + devfs

[kaoru bsd tnes nec co jp]

Hi,

When I executed the following commands, I get oops 
running under 2.4.19-rc3 kernel with LVM-1.0.5 + devfs.

# lvrename /dev/vg11/lv11_01 /dev/vg11/lv11_01new
# vgdisplay -v vg11

I executed "cat /proc/partitions" instead of "vgdisplay",
oops occurred, too. 

I think that the cause of this is the return value of 
lvm_fs_create_lv() is ignored which is called within 
a lvm_do_lv_rename function.

I made the following patch for this problem, and it seems 
to work. Any comments? 

---8<-----------8<----------8<----------8<----------8<----------

--- linux/drivers/md/lvm.c.orig  Fri Aug  2 08:51:06 2002
+++ linux/drivers/md/lvm.c       Fri Aug  2 08:50:48 2002
@@ -2710,6 +2710,7 @@
                {
                        lvm_fs_remove_lv(vg_ptr, lv_ptr);
                        strncpy(lv_ptr->lv_name, lv_req->lv_name, NAME_LEN);
+                       lvm_gendisk.part[MINOR(lv_ptr->lv_dev)].de =
                        lvm_fs_create_lv(vg_ptr, lv_ptr);
                        break;
                }

---8<-----------8<----------8<----------8<----------8<----------

--------------------
Kaoru