[linux-lvm] Patch for vg_status_with_pv_and_lv.c
Heinz J . Mauelshagen
mauelshagen at sistina.com
Mon May 6 08:33:05 UTC 2002
Dale,
thanks for the patch.
Soon to be in CVS...
Regards,
Heinz -- The LVM Guy --
On Wed, May 01, 2002 at 12:22:13PM -0700, Stephenson, Dale wrote:
> I'm not sure if I sent this patch out when I generated it (I'm guessing not,
> since it doesn't seem to be different in CVS), so I'm sending it out now.
>
> This patch solves a segfault in lvscan. When there was a problem reading
> the lv_list (lv_status_all_lv_of_vg() returned an error) in
> vg_status_with_pv_and_lv.c, the routine would still call
> vg_setup_pointers_for_snapshots. Since the error had prevented setting up
> the vg->lv[] array, this didn't work. I just moved
> vg_setup_pointers_for_snapshot inside the no error case. No one uses the vg
> if an error is returned, so it doesn't matter that it isn't setup for
> snapshots :->.
>
> Dale J. Stephenson
> steph at snapserver.com
>
> --- 1.0.3/tools/lib/vg_status_with_pv_and_lv.c.orig Thu Apr 11 10:45:18
> 2002
> +++ 1.0.3/tools/lib/vg_status_with_pv_and_lv.c Thu Apr 11 10:45:41 2002
> @@ -57,10 +57,10 @@
> for ( p = 0; pv[p] != NULL; p++) (*vg)->pv[p] = pv[p];
> for ( ; p < (*vg)->pv_max; p++) (*vg)->pv[p] = NULL;
> for ( l = 0; l < (*vg)->lv_max; l++) (*vg)->lv[l] = lv[l];
> - }
>
> - /* Set up core pointers for snapshots */
> - vg_setup_pointers_for_snapshots ( *vg);
> + /* Set up core pointers for snapshots */
> + vg_setup_pointers_for_snapshots ( *vg);
> + }
>
> debug_leave ( "vg_status_with_pv_and_lv -- LEAVING with ret: %d\n",
> ret);
> return ret;
>
> _______________________________________________
> linux-lvm mailing list
> linux-lvm at sistina.com
> http://lists.sistina.com/mailman/listinfo/linux-lvm
> read the LVM HOW-TO at http://www.sistina.com/lvm/Pages/howto.html
*** Software bugs are stupid.
Nevertheless it needs not so stupid people to solve them ***
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Heinz Mauelshagen Sistina Software Inc.
Senior Consultant/Developer Am Sonnenhang 11
56242 Marienrachdorf
Germany
Mauelshagen at Sistina.com +49 2626 141200
FAX 924446
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
More information about the linux-lvm
mailing list