[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[linux-lvm] [PATCH LVM2 2/2] fix lvconvert to setup mirror constraints



This patch fixes this problem:
  - 'lvconvert' from corelog allocates log from the same PV
    with other image. It spoils redundancy.

The patch depends on fix-mirror-alloc-anywhere.patch posted formerly.

Thanks,
-- 
Jun'ichi Nomura, NEC Corporation of America
diff -X dontdiff -urp LVM2/tools/lvconvert.c LVM2.fixed/tools/lvconvert.c
--- LVM2/tools/lvconvert.c	2006-08-30 05:57:31.000000000 -0400
+++ LVM2.fixed/tools/lvconvert.c	2006-09-15 00:00:33.000000000 -0400
@@ -281,15 +281,10 @@ static int lvconvert_mirrors(struct cmd_
 			if (lp->mirrors == existing_mirrors) {
 				if (!seg->log_lv && !arg_count(cmd, corelog_ARG)) {
 					/* No disk log present, add one. */
-					/* FIXME: Why doesn't this work?  Without
-					   it, we will probably put the log on the
-					   same device as a mirror leg.
-					  if (!(parallel_areas = build_parallel_areas_from_lv(cmd, lv))) {
-					  stack;
-					  return 0;
-					  }
-					*/
-					parallel_areas = NULL;
+					if (!(parallel_areas = build_parallel_areas_from_lv(cmd, lv))) {
+						stack;
+						return 0;
+					}
 					if (!lv_mirror_percent(cmd, lv, 0, &sync_percent, NULL)) {
 						log_error("Unable to determine mirror sync status.");
 						return 0;

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]