[linux-lvm] clvmd on openais
Christine Caulfield
ccaulfie at redhat.com
Wed Apr 23 09:54:22 UTC 2008
Xinwei Hu wrote:
> 2008/4/23, Christine Caulfield <ccaulfie at redhat.com>:
>> Xinwei Hu wrote:
>> > 2008/4/23, Christine Caulfield <ccaulfie at redhat.com>:
>> >> Xinwei Hu wrote:
>> >> > Hi all,
>> >> > clvmd-openais.c uses saLckResourceLockAsync and
>> >> > saLckResourceUnlockAsync. But they then pthread_cond_wait the lock
>> >> > operation to finished.
>> >> >
>> >> > Since we have to wait, why not switch to use saLckResourceLock and
>> >> > saLckResourceUnlock directly ? Are there any reasons behind this ?
>> >> >
>> >>
>> >>
>> >> It's mainly because the code was copied and editted from the other
>> >> cluster systems, I think :-)
>> > Then I propose this patch to switch over. ;)
>>
>>
>>
>> Thanks, but that patch seems to have got corrupted or something, it
>> doesn't apply to head of CVS. can you send it again please ?
>>
>>
>> Hunk #3 FAILED at 295.
>> Hunk #4 succeeded at 315 (offset -8 lines).
>> Hunk #6 succeeded at 478 (offset -8 lines).
>> patch: **** malformed patch at line 161: @@ -590,15 +536,13 @@
>>
> Take 2.
> Against CVS head now. Please help to review ;)
That looks good to me and it tests out OK.
It's now in CVS, thank you very much.
--
Chrissie
More information about the linux-lvm
mailing list