[linux-lvm] system-config-lvm bug with using lv as swap space

[wu jessinay]

Hi,all
I have encountered several bugs of system-config-lvm.
The first one is if there is a logical volume entry in /etc/fstab
and another raw device entry for swap
such as
/dev/my_vg1/my_lv1   swap  swap  defaults 0 0
/dev/hda1       swap    swap   defaults   0  0

then if we use system-config-lvm to remove my_lv1,
Not only the my_lv1 entry,but all other swap entries in /etc/fstab will get
removed.

After some investigation on the system-config-lvm python source file.
It seems that the problem is in the InputController.py file.
When we click the remove button,the program will check if there is any
entry of the removed logical volume in /etc/fstab.
If any entry exist in /etc/fstab, it will remove this line from /etc/fstab
so that when the system reboot it won't mount this logical volume(since it
has been removed).

This procedure is OK.However,the program will delete the corresponding entry
in the following way:
1.check what is the mount point of this logical volume.(in our case it is
swap)
2.search /etc/fstab file,delete all the entries with the same mount
point.This won't result in any trouble if the logical volume is mounted on
/mnt/mylv1 .but if the mount point is swap ,it will delete all swap entries
in /etc/fstab file.

I have created a patch to solve this problem,which modify the removing
procedure if the mount point is swap.

There is several other bugs with system-config-lvm but the root cause should
be the same.

this problem exist in enterprise linux 5 and enterprise linux 5 U1.
Is this a fixed bug?Any advice is appreciated!

Thanks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/linux-lvm/attachments/20081208/a7cb0b12/attachment.htm>