Re: [linux-lvm] merging snapshots and lvs bug

[Mike Snitzer <snitzer redhat com>]

On Fri, Jul 15 2011 at  6:14pm -0400,
Alasdair G Kergon <agk redhat com> wrote:

> On Fri, Jul 15, 2011 at 01:01:15PM -0700, ben wrote:
> > It isn't a special case. Invalid snaps use capital 'S' in the first column and 
> > so do merging snaps. The invalid snap 'S' dates back to old versions of LVM. 
> > Here we have three snaps, the first is invalid, the second is merging and the 
> > last is normal:
>  
> Oh, yes, I see.  Curiously the man page used to mention that and it got
> replaced with S for merging.
> 
> So do you think we should remove that capitalisation, as per the man page
> I quoted?

Yes, I think we should remove the capitalization.

It is the repstr[0] = toupper(repstr[0]); in the
lib/metadata/lv.c:lv_attr_dup() block I just quoted in a different mail
(re: --merge bug).