[lvm-devel] [PATCH 6/6] Remove now-unused vg_lock_and_read.
Petr Rockai
me at mornfall.net
Thu Jan 15 10:34:44 UTC 2009
Thu Jan 15 10:52:08 CET 2009 Petr Rockai <me at mornfall.net>
* Remove now-unused vg_lock_and_read.
diff -rN -u -p old-temp.23590/lib/metadata/metadata.c new-temp.23590/lib/metadata/metadata.c
--- old-temp.23590/lib/metadata/metadata.c 2009-01-15 11:27:15.771751458 +0100
+++ new-temp.23590/lib/metadata/metadata.c 2009-01-15 11:27:15.819751622 +0100
@@ -2424,50 +2424,6 @@ int vg_check_status(const struct volume_
}
/*
- * vg_lock_and_read - consolidate vg locking, reading, and status flag checking
- *
- * Returns:
- * NULL - failure
- * non-NULL - success; volume group handle
- */
-vg_t *vg_lock_and_read(struct cmd_context *cmd, const char *vg_name,
- const char *vgid,
- uint32_t lock_flags, uint32_t status_flags,
- uint32_t misc_flags)
-{
- struct volume_group *vg;
- int consistent = 1;
-
- if (!(misc_flags & CORRECT_INCONSISTENT))
- consistent = 0;
-
- if (!validate_name(vg_name)) {
- log_error("Volume group name %s has invalid characters",
- vg_name);
- return NULL;
- }
-
- if (!lock_vol(cmd, vg_name, lock_flags)) {
- log_error("Can't get lock for %s", vg_name);
- return NULL;
- }
-
- if (!(vg = vg_read_internal(cmd, vg_name, vgid, &consistent)) ||
- ((misc_flags & FAIL_INCONSISTENT) && !consistent)) {
- log_error("Volume group \"%s\" not found", vg_name);
- unlock_vg(cmd, vg_name);
- return NULL;
- }
-
- if (!vg_check_status(vg, status_flags)) {
- unlock_vg(cmd, vg_name);
- return NULL;
- }
-
- return vg;
-}
-
-/*
* Create a (vg_t) volume group handle from a struct volume_group pointer and a
* possible failure code. Zero failure code = success.
*/
diff -rN -u -p old-temp.23590/lib/metadata/metadata-exported.h new-temp.23590/lib/metadata/metadata-exported.h
--- old-temp.23590/lib/metadata/metadata-exported.h 2009-01-15 11:27:15.771751458 +0100
+++ new-temp.23590/lib/metadata/metadata-exported.h 2009-01-15 11:27:15.819751622 +0100
@@ -95,10 +95,6 @@ struct pv_segment;
#define FMT_UNLIMITED_STRIPESIZE 0x00000100U /* Unlimited stripe size? */
#define FMT_RESTRICTED_READAHEAD 0x00000200U /* Readahead restricted to 2-120? */
-/* LVM2 external library flags */
-#define CORRECT_INCONSISTENT 0x00000001U /* Correct inconsistent metadata */
-#define FAIL_INCONSISTENT 0x00000002U /* Fail if metadata inconsistent */
-
/* Mirror conversion type flags */
#define MIRROR_BY_SEG 0x00000001U /* segment-by-segment mirror */
#define MIRROR_BY_LV 0x00000002U /* mirror using whole mimage LVs */
More information about the lvm-devel
mailing list